Skip to content

Add Gitlink support#144

Open
roman-kozachenko wants to merge 5 commits intomasterfrom
feature/gitlink
Open

Add Gitlink support#144
roman-kozachenko wants to merge 5 commits intomasterfrom
feature/gitlink

Conversation

@roman-kozachenko
Copy link
Copy Markdown
Contributor

@roman-kozachenko roman-kozachenko commented Feb 20, 2019

#85

aensidhe
aensidhe requested changes Feb 20, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@aensidhe aensidhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See other projects on how to do that

@roman-kozachenko
Copy link
Copy Markdown
Contributor Author

roman-kozachenko commented Feb 20, 2019 •
edited
Loading

@aensidhe I took a look at projects supporting gitlink, and as I see just Install-Package GitLink is not enough for enabling it.
Further investigation is needed.
That is quite strange, but project successfully builds with -c Debug.
Will close pull request for now.

@aensidhe
Copy link
Copy Markdown
Member

aensidhe commented Feb 21, 2019

https://github.com/progaudi/msgpack.spec/blob/a219eb0b7b9e3048c314059c0c0342a0a776e041/src/msgpack.spec/msgpack.spec.csproj#L48

@aensidhe aensidhe reopened this Feb 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aensidhe aensidhe aensidhe requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@roman-kozachenko @aensidhe