Improve Timeout and Error Handling v2 #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added logic to detect blocked shells Fixed Temp file deletion Re-Design Timeout and Error detection -Properly wait for the end of both input Streams -Push End_Script_String also to stderr Added code for closing of blocked shells (jna or java9 approach) Fixed visibility of executeScript(BufferedReader srcReader, String parms)
Removed Timeout Handling. The PowerShell class itself will timeout in Line: https://github.com/Harinus/jPowerShell/blob/aa8d863643281bbf7b964a47026ee8a956b220d7/src/main/java/com/profesorfalken/jpowershell/PowerShell.java#L216 Because the reading takes place while (!result.isDone() || !resultError.isDone()) in the seperate threadpool. No longer rely on reader.ready(), we know we will get the Script end tag.
Owner
|
Hi, Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Greetings profesorfalken,
I am still using your library and wanted to share some improvements I did. This is basically a replacement for #22. See the two commit messages below for details and the description of the original PR.
I have noticed your comments and simplified my changes. However those are quite important IMO for error and timeout handling and already very well tested with about 0.5 million executions in my environment.
There is just one thing I noticed and that can possibly not be fixed: Once someone uses "throw" or "return" in their powershell script it will terminate it and therefore never read the end tag from the stream. (Affects both your and my version). Maybe add that to the documentation just in case.
Hopefully this can be merged so, I can switch back to the main branch and get rid of my custom version.
Best regards,
Harinus