Добавил эндпоинт для удаления rental session #119
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💩 Code linting failed, use |
Member
Author
|
Проверку на правильность удаления сессий и страйков протестил |
Zimovchik
approved these changes
Nov 5, 2025
| RentalSession.query(session=db.session) | ||
| .filter(RentalSession.status == RentStatus.ACTIVE) | ||
| .filter(RentalSession.deadline_ts < datetime.datetime.now(tz=datetime.timezone.utc)) | ||
| .filter(RentalSession.is_deleted == False) |
| exist_session_item: list[RentalSession] = ( | ||
| RentalSession.query(session=db.session) | ||
| .filter(RentalSession.user_id == user.get("id"), RentalSession.item_type_id == item_type_id) | ||
| .filter(RentalSession.is_deleted == False) |
| session = RentalSession.get(id=session_id, session=db.session) | ||
| if not session: | ||
| raise ObjectNotFound(RentalSession, session_id) | ||
| if session.status == RentStatus.ACTIVE or session.status == RentStatus.RESERVED: |
Comment on lines
495
to
496
| if not session: | ||
| raise ObjectNotFound(RentalSession, session_id) |
| raise ForbiddenAction(RentalSession) | ||
| RentalSession.delete(id=session_id, session=db.session) | ||
| return StatusResponseModel( | ||
| status="Success", message="Rental session has been deleted", ru="Сессия удалена из RentalAPI" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Изменения
При удалении item идет проверка на наличие сессий не являющихся активными, зарезервированными, просроченными, если такие есть то они происходит софт делит для сессий и их страйков, также удаляются events^ связанные с сессиями.
Детали реализации
В модели бд ничего не менял, так как любые доп функции для поля там работают только при хард делитах, которые мы не поддерживаем.
Check-List
Тесты падают уже давно, надо будет стажерам дать их исправить)))
blackиisortдля Back-End илиPrettierдля Front-End?