Лайки к комментариям #95
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 14, 2025 13:43
Summary
|
Member
Author
|
Что нужно обсудить/сделать:
|
Member
Если функционально это аналогично, я бы сказал, что нужны |
Temmmmmo
reviewed
Mar 7, 2025
| from sqlalchemy import UUID, Boolean, DateTime | ||
| from sqlalchemy import Enum as DbEnum | ||
| from sqlalchemy import ForeignKey, Integer, String, UnaryExpression, and_, func, nulls_last, or_, true | ||
| from sqlalchemy import ForeignKey, Integer, String, UnaryExpression, and_, func, nulls_last, or_, select, true |
| class CommentLike(BaseDbModel): | ||
| id: Mapped[int] = mapped_column(Integer, primary_key=True) | ||
| user_id: Mapped[int] = mapped_column(Integer, nullable=False) | ||
| comment_uuid: Mapped[uuid.UUID] = mapped_column(UUID, nullable=False) |
Member
There was a problem hiding this comment.
а мб отношение полноценное сделаем?
Comment on lines
+185
to
+194
| like_counts = ( | ||
| select(CommentLike.comment_uuid, func.count(CommentLike.id).label('like_count')) | ||
| .where(CommentLike.is_deleted == False) | ||
| .group_by(CommentLike.comment_uuid) | ||
| .alias("like_counts") | ||
| ) | ||
| # получаем комменты с лайками к ним | ||
| comments_query = select(Comment, func.coalesce(like_counts.c.like_count, 0).label('like_count')).outerjoin( | ||
| like_counts, Comment.uuid == like_counts.c.comment_uuid | ||
| ) |
Member
There was a problem hiding this comment.
мб вынесем всю эту логику в гибрид-метод?
Member
Author
There was a problem hiding this comment.
это я так, на скорую руку писал, нужно будет переделать, да
Member
Author
There was a problem hiding this comment.
мне кажется, я тогда с джоином не разобрался как его без селекта сделать
| else: | ||
| if "rating.comment.review" not in [scope['name'] for scope in user.get('session_scopes')]: | ||
| raise ForbiddenAction(Comment) | ||
| comments_query = comments_query.where(Comment.review_status == ReviewStatus.PENDING) |
Member
There was a problem hiding this comment.
можно через фильтр а не через where, чтобы стилистику кода сохранять
|
|
||
| comments_query = comments_query.offset(offset).limit(limit) | ||
|
|
||
| comments_with_likes = db.session.execute(comments_query).all() |
Member
There was a problem hiding this comment.
ну вот так не пишем, тоже не наш стиль бэкенда
|
💩 Code linting failed, use |
Member
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Изменения
Добавление функционала лайков на комментарии.
Детали реализации
Check-List
blackиisortдля Back-End илиPrettierдля Front-End?