lecturer-rank-route #140
Closed
lecturer-rank-route #140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage Report
Summary
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Zimovchik
reviewed
Aug 23, 2025
Comment on lines
19
to
37
| def upgrade(): | ||
| op.create_table( | ||
| 'lecturer_rating', | ||
| sa.Column('id', sa.Integer(), nullable=False, comment='Идентификатор препода'), | ||
| sa.Column( | ||
| 'mark_weighted', sa.Float(), nullable=False, comment='Взвешенная оценка преподавателя, посчитана в dwh' | ||
| ), | ||
| sa.Column( | ||
| 'mark_kindness_weighted', sa.Float(), nullable=False, comment='Взвешенная оценка доброты, посчитана в dwh' | ||
| ), | ||
| sa.Column( | ||
| 'mark_clarity_weighted', sa.Float(), nullable=False, comment='Взвешенная оценка понятности, посчитана в dwh' | ||
| ), | ||
| sa.Column( | ||
| 'mark_freebie_weighted', sa.Float(), nullable=False, comment='Взвешенная оценка халявности, посчитана в dwh' | ||
| ), | ||
| sa.Column('rank', sa.Integer(), nullable=False, comment='Место в рейтинге, посчитана в dwh'), | ||
| sa.PrimaryKeyConstraint('id'), | ||
| ) |
Member
There was a problem hiding this comment.
у тебя же не создастся просто такая табличка, потому что nullable = False, но нет дефолтного значения
rating_api/models/db.py
Outdated
Comment on lines
217
to
223
| class LecturerRating(BaseDbModel): | ||
| id: Mapped[int] = mapped_column(Integer, primary_key=True, comment="Идентификатор препода") | ||
| mark_weighted: Mapped[float] = mapped_column(Float, comment="Взвешенная оценка преподавателя, посчитана в dwh") | ||
| mark_kindness_weighted: Mapped[float] = mapped_column(Float, comment="Взвешенная оценка доброты, посчитана в dwh") | ||
| mark_clarity_weighted: Mapped[float] = mapped_column(Float, comment="Взвешенная оценка понятности, посчитана в dwh") | ||
| mark_freebie_weighted: Mapped[float] = mapped_column(Float, comment="Взвешенная оценка халявности, посчитана в dwh") | ||
| rank: Mapped[int] = mapped_column(Integer, comment="Место в рейтинге, посчитана в dwh") |
Member
There was a problem hiding this comment.
либо поставь nullable = True, либо default = True
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Изменения
Детали реализации
Check-List
blackиisortдля Back-End илиPrettierдля Front-End?