-
Notifications
You must be signed in to change notification settings - Fork 0
Savateykin #314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
yaroslavsavateykin
wants to merge
12
commits into
main
Choose a base branch
from
savateykin
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Savateykin #314
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
2e80aff
atm
5ab79ab
sdjkfldsj
cca87d3
adsjdsfjlk
f08088c
Merge branch 'tmp'
216818b
additional_data json type check
582078a
additional_data json check
582795e
additional_data json check
bd716cb
additional_data json check
32219fe
jsonb_valid function usage
7e3d45e
jsonb_valid usage
9fbc9e6
regular expression json check
b150d84
jsonb_valid removal
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -24,10 +24,12 @@ FROM | |
| LATERAL ( | ||
| SELECT value AS elem | ||
| FROM jsonb_array_elements( | ||
| CASE | ||
| WHEN additional_data = '' THEN jsonb_build_array('{}'::jsonb) | ||
| CASE | ||
| WHEN additional_data IS NULL OR additional_data = '' THEN jsonb_build_array('{}'::jsonb) | ||
| --WHEN NOT jsonb_valid(additional_data) THEN jsonb_build_array('{}'::jsonb) | ||
| WHEN additional_data ~ '^\{.*\}$' THEN additional_data::jsonb | ||
| WHEN jsonb_typeof(additional_data::jsonb) = 'array' THEN additional_data::jsonb | ||
| ELSE jsonb_build_array(additional_data::jsonb) | ||
| ELSE jsonb_build_array(additional_data::jsonb) | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. а чем 31 и 32 строчки отличаются по смыслу? иначе преобразуем в массив джейсонов точно ли это имел в виду? |
||
| END | ||
| ) | ||
| ) AS expanded | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
убери комментарий