Fix can't pickle local object in calcHydrogenBondsTrajectory #2196
+53
−18
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix pickle error in calcInteractionsMultipleFrames for Windows multiprocessing
Fixes the pickle error that occurs when using
calcHydrogenBondsTrajectoryand other trajectory analysis functions with multiprocessing on Windows. The issue was caused by local nested functions that cannot be pickled by Python's multiprocessing module, especially on Windows which uses the "spawn" method instead of "fork".Changes Made
Refactored local functions to module-level functions:
_analyseFrameTrajectory()- Worker function for trajectory frame analysis_analyseFrameTrajectoryWrapper()- Multiprocessing wrapper for trajectory processing with managed lists_analyseFrameMultiModel()- Worker function for multi-model PDB analysis_analyseFrameMultiModelWrapper()- Multiprocessing wrapper for multi-model PDB processing with managed listsAll context variables (atoms, interaction_type, kwargs, etc.) are now passed as explicit function parameters instead of being captured from closure, making the functions picklable across all platforms.
Affected Functions
This fix applies to all trajectory calculation functions that use
calcInteractionsMultipleFrames:calcHydrogenBondsTrajectorycalcSaltBridgesTrajectorycalcRepulsiveIonicBondingTrajectorycalcPiStackingTrajectorycalcPiCationTrajectorycalcHydrophobicTrajectorycalcDisulfideBondsTrajectoryTesting
testHydrogenBonds,testAllInteractionsCalc,testAllInteractionsCalcSerialThe changes are minimal and maintain backward compatibility while enabling multiprocessing to work correctly on all platforms, including Windows.
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.