Skip to content

Detecting if Rails is available on the bin/console#15

Open
mpmenne wants to merge 2 commits intoprodis:masterfrom
mpmenne:fix-bin-console
Open

Detecting if Rails is available on the bin/console#15
mpmenne wants to merge 2 commits intoprodis:masterfrom
mpmenne:fix-bin-console

Conversation

@mpmenne
Copy link

@mpmenne mpmenne commented Nov 11, 2020

This PR detects if Rails is available before attempting to start the rails console in production.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 6cd8ab3 on mpmenne:fix-bin-console into b73bd1e on prodis:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 6cd8ab3 on mpmenne:fix-bin-console into b73bd1e on prodis:master.

@prodis prodis self-requested a review November 12, 2020 09:22
@prodis prodis added the bug label Nov 12, 2020
@@ -4,4 +4,9 @@ require 'bundler/setup'
require 'wannabe_bool'

require 'pry'
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest to move this line to inside the condition if Pry is defined.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep! Thank you for that comment. After using this PR I noticed some issues. Will followup with a fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants