Skip to content

Deprecate ProblemStatus enum to mark it internal-only #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
malczuuu merged 1 commit into from
Mar 14, 2026
Merged

Deprecate ProblemStatus enum to mark it internal-only #34

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/main/java/io/github/problem4j/core/AbstractProblemBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,12 @@ public ProblemBuilder status(int status) {
*
* @param status the {@link ProblemStatus} representing the HTTP status
* @return this builder instance for chaining
* @deprecated {@link ProblemStatus} will be considered an internal utility of Problem4J Core and
* will be made package-private in a future major release. The decision was made as each HTTP
* framework most likely has its own enum for HTTP status codes, and there's no real value in
* trying to maintain a separate, framework-agnostic enum that mirrors HTTP status codes.
*/
@Deprecated
@Override
public ProblemBuilder status(@Nullable ProblemStatus status) {
return status != null ? status(status.getStatus()) : status(0);
Expand Down
5 changes: 5 additions & 0 deletions src/main/java/io/github/problem4j/core/ProblemBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,12 @@ public interface ProblemBuilder {
*
* @param status the {@link ProblemStatus} representing the HTTP status
* @return this builder instance for chaining
* @deprecated {@link ProblemStatus} will be considered an internal utility of Problem4J Core and
* will be made package-private in a future major release. The decision was made as each HTTP
* framework most likely has its own enum for HTTP status codes, and there's no real value in
* trying to maintain a separate, framework-agnostic enum that mirrors HTTP status codes.
*/
@Deprecated
ProblemBuilder status(@Nullable ProblemStatus status);

/**
Expand Down
5 changes: 5 additions & 0 deletions src/main/java/io/github/problem4j/core/ProblemStatus.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,12 @@
* @see <a href="https://http.cat/">HTTP Cats</a>
* @see <a href="https://developer.mozilla.org/en-US/docs/Web/HTTP/Reference/Status">HTTP response
* status codes - HTTP | MDN</a>
* @deprecated {@link ProblemStatus} will be considered an internal utility of Problem4J Core and
* will be made package-private in a future major release. The decision was made as each HTTP
* framework most likely has its own enum for HTTP status codes, and there's no real value in
* trying to maintain a separate, framework-agnostic enum that mirrors HTTP status codes.
*/
@Deprecated
public enum ProblemStatus {

/**
Expand Down