Skip to content

chore: update @probelabs/probe to v0.6.0-rc174 #272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
probelabs wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: update @probelabs/probe to v0.6.0-rc174 #272

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@
"@octokit/auth-app": "^8.1.0",
"@octokit/core": "^7.0.3",
"@octokit/rest": "^22.0.0",
"@probelabs/probe": "^0.6.0-rc173",
"@probelabs/probe": "^0.6.0-rc174",

Check warning on line 99 in package.json

View check run for this annotation

probelabs / Visor: architecture

architecture Issue 

Dependency update risks breaking existing API workarounds. The codebase uses type casting to pass unsupported options (disableTools, allowedTools) to ProbeAgent, which may break with version updates.
Raw output 
Consider implementing a compatibility layer or abstraction to isolate ProbeAgent-specific workarounds. Monitor for breaking changes in release notes and test thoroughly after updates.

Check warning on line 99 in package.json

View check run for this annotation

probelabs / Visor: architecture

architecture Issue 

High coupling to @probelabs/probe throughout codebase creates maintenance risk. Multiple components directly import and extend ProbeAgent interfaces.
Raw output 
Consider introducing an abstraction layer (Adapter pattern) to reduce coupling. This would make it easier to switch providers or handle API changes.

Check warning on line 99 in package.json

View check run for this annotation

probelabs / Visor: quality

architecture Issue 

Dependency update from @probelabs/probe@0.6.0-rc173 to @probelabs/probe@0.6.0-rc174 should include verification of compatibility with existing API usage patterns, particularly around the known issues with disableTools and allowedTools options that are currently passed but silently ignored by ProbeAgent.
Raw output 
Verify that the new version maintains compatibility with existing ProbeAgent usage patterns. Consider testing the known API mismatches (disableTools, allowedTools) to ensure they still behave as expected or have been improved.

Check warning on line 99 in package.json

View check run for this annotation

probelabs / Visor: quality

testing Issue 

The mock implementation in __mocks__/@probelabs/probe.ts should be verified against the new ProbeAgent API to ensure test compatibility, particularly around the TracedProbeAgent interface extensions used in the codebase.
Raw output 
Run the test suite after this dependency update to ensure all tests pass. Pay special attention to tests that use ProbeAgent directly or test the AI review functionality.
"@types/commander": "^2.12.0",
"@types/uuid": "^10.0.0",
"ajv": "^8.17.1",
Expand Down
Loading