Cleaner separation of native code#275
Open
davexparker wants to merge 4 commits intoprismmodelchecker:masterfrom
Open
Cleaner separation of native code#275davexparker wants to merge 4 commits intoprismmodelchecker:masterfrom
davexparker wants to merge 4 commits intoprismmodelchecker:masterfrom
Conversation
Calls to JDD.xx() and PrismNative.xx() are pushed into separate libraries. Currently those libraries are always created but will later be optional. Prism also also now stores a (static) workingDirectory, as set by the -dir switch or when running PRISM in Nailgun mode. There are methods to resolve filenames with respect to this. Currently unused. In fact, setting the working directory currently only works via the native call to change cwd.
PrismFileLog now defaults to using non-native code, i.e., PrintStreams, but can be switched cleanly to a native implementation using useNative(). Code using native libraries (mainly symbolic engines) implement new interface PrismNativeComponent, which triggers the switch on creation.
Native shared libraries can be absent when using the explicit engine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
prism.PrismPrismFileLogimplementation initially