PrismLog improvements#274
Merged
davexparker merged 8 commits intoprismmodelchecker:masterfrom Mar 1, 2026
Merged
Conversation
Various code, notably for exporting, uses:
try (PrismLog out = getPrismLogForFile(file)) { ... }
to create either a fresh file for export, or a pointer to the log
when file==null. But, when using when the log is a file (with -mainlog),
the auto-close caused the file to be closed prematuraly. Examples:
* prism poll2.sm -ss -mainlog tmp.log
* prism poll2.sm -exportmodel stdout.tra -ex -mainlog tmp.log
This is snow fixed, using a log wrapper class.
The Java implementation is not yet used anywhere.
Previously, the way to test for successful file opening was to call ready() immediately afterwards, but this is often not done.
Also make sure that close() always triggers flush() first. Remove an unusewd GUI log.
davexparker
force-pushed
the
log
branch
3 times, most recently
from
7ec8751 to
c815584
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tidy up PrismLog, fix some bugs and more cleanly allow both pure Java and native implementations.