Added optional lang for retrieving docs & fixed unit test #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test |
MarcMcIntosh
left a comment
MarcMcIntosh
left a comment
There was a problem hiding this comment.
Tests pass on tailsdotcom repository :)
Try and merge (locally) and re-test.
srenault
requested changes
Nov 7, 2019
Contributor
srenault
left a comment
srenault
left a comment
There was a problem hiding this comment.
Thanks for you PR,
For get_by_uid, get_by_id, get_by_ids, the default language should be * (meaning we search over all languages). You can see how we did it for the javascript sdk here: https://github.com/prismicio/prismic-javascript/blob/master/src/ResolvedApi.ts#L182
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.