Conversation
Polichinel
commented
Jun 10, 2024
Collaborator
Author
Polichinel
left a comment
There was a problem hiding this comment.
Comments to Sara's comments.
Generally followed advice. changed os the pathlib throughout the script, renamed some script and relocated to central scripts to new dir src/management as they seemed too important to hide in utils, but we still want a clean main.py. LMKWYT.
Add some new functions to set_path script to accommodate ESCW PR, but with a change so the PATH_MODEL has its own function (setup_model_path) and is not part of the setup_data_paths
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Created a main.py for purple alien.
But more importantly, this is to be seen as a suggestion to a more general structure. I.e. both how the main is structured, the use of agr parse, and the associated common_utils. But also further the way that the hierarchic of scripts main.pt<-model_run_handlers<-model_run_managers<-(training, testing, forecasting scripts respectively) ids set up.
We should think about how much of this we can abstract out to common_utils. Of course, the deeper we go into these hierarchies the less we should expect the code to be generalizable.
Thanks in advance for any notes and feedback!