Draft
Conversation
smellycloud
requested review from
Polichinel,
jimdale,
lujzi05 and
xiaolong0728
4 tasks
lujzi05
reviewed
Nov 5, 2024
There was a problem hiding this comment.
Comment: It basically follows the md&d_python_style_guide.md but with more details and examples.
Questions:
- What do you want to write to the Decision part? Isn't it the decision that we want to use these conventions?
- Do you want to include to use of
''and""? In dictionaries, config files, etc.
xiaolong0728
approved these changes
Nov 5, 2024
jimdale
approved these changes
Nov 7, 2024
Collaborator
jimdale
left a comment
jimdale
left a comment
There was a problem hiding this comment.
I think this looks good - it will make the codebase much easier to read
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.