You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thank you, Garret, for your efforts. Here are my review and comments.
One thing I wonder, which Jonas is better equipped to comment on, is the number of .zip files to download, especially given their sizes. Is it a good idea to have users download 36 .zip files in one batch? This also makes me question using beta_test and folder_size, since users must download the raw data into their folder before they can make use of get_pgfile(). So I'm not sure if beta_test and folder_size arguments are adding what you intend them to do?
Also:
Avoid loading libraries within functions (as in function 2), use terra::rast() instead.
There should not be any empty space between the end of the documentation (typically with @export) and the start of the function.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.