Add PyTorch 2.x compatibility and modern GPU support (CUDA 12.8, RTX 50 series)#101
Open
chansoopark98 wants to merge 2 commits intoprinceton-vl:mainfrom
Open
Add PyTorch 2.x compatibility and modern GPU support (CUDA 12.8, RTX 50 series)#101chansoopark98 wants to merge 2 commits intoprinceton-vl:mainfrom
chansoopark98 wants to merge 2 commits intoprinceton-vl:mainfrom
Conversation
Adds a detailed analysis report for DPVO (Deep Patch Visual Odometry), covering its architecture, algorithms, and performance. Also includes a comprehensive installation guide, addressing dependencies, build processes, and troubleshooting for modern NVIDIA GPUs. The guide emphasizes ABI compatibility for Pangolin and provides solutions for common CUDA and CMake errors.
|
Modernize this project would be tremendously helpful |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for modern NVIDIA GPUs (RTX 40/50 series) with CUDA 12.8 and PyTorch 2.8.0.
Changes
1. PyTorch 2.x API Compatibility
Fixed deprecated
.type()calls that cause build failures with PyTorch 2.x:dpvo/altcorr/correlation_kernel.cu- 4 fixesdpvo/lietorch/src/lietorch_gpu.cu- 19 fixesdpvo/lietorch/src/lietorch_cpu.cpp- 19 fixesdpvo/lietorch/include/dispatch.h- Updated macroBefore (PyTorch 1.x):
AT_DISPATCH_FLOATING_TYPES(tensor.type(), "kernel_name", ([&] { ... }));
After (PyTorch 2.x):
AT_DISPATCH_FLOATING_TYPES(tensor.scalar_type(), "kernel_name", ([&] { ... }));
2. DPViewer Build Fixes
DPViewer/CMakeLists.txt:
DPViewer/setup.py:
3. Installation Documentation
Added comprehensive
INSTALL.mdwith:--no-build-isolationrequirementMotivation
The original DPVO was built for PyTorch 1.x and older NVIDIA GPUs. This PR enables:
.type()methodTesting
Tested on:
Verified:
Breaking Changes
None. All changes are backward compatible.
(Installation Guide)
INSTALL.md