feat: Add Support for Zero Fee Addresses #53
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shaspitz
reviewed
Nov 25, 2024
shaspitz
reviewed
Nov 25, 2024
shaspitz
reviewed
Nov 25, 2024
| st.state.AddBalance(treasuryAccount, bothFees) | ||
|
|
||
| // @shaspitz do we note want to also remove the fee from the sender account, even when we increment the treasury account? | ||
| if slices.Contains(st.evm.Config.ZeroFeeAddresses, sender.Address()) { |
There was a problem hiding this comment.
don't we use vm.config now from the cli flag above?
Author
There was a problem hiding this comment.
That is vm.config. it's just called st.evm.Config
shaspitz
approved these changes
Nov 25, 2024
shaspitz
left a comment
shaspitz
left a comment
There was a problem hiding this comment.
Thanks! It's worth one of us testing this before merging, we'll also need to integrate with nomad keystore setup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces support for zero fee addresses in the Ethereum state transition logic and configuration. This will ensure accounts like the Oracle and Relayer for the bridge never run out of funds.
Note: to set the whitelisted accounts, you must configure them in the genesis file.