Remove redirects for skeleton components#416
Conversation
adierkens
temporarily deployed
to
github-pages
GitHub Actions
Inactive
There was a problem hiding this comment.
Pull request overview
Updates the site’s redirect configuration to stop redirecting certain legacy URLs (notably skeleton component routes) and to adjust an accessibility redirect target.
Changes:
- Removed redirect rules for legacy
/components/skeleton-*(and/figma) paths. - Updated the
/accessibility/semantic-htmlredirect destination to/accessibility/design-guidance/semantic-html-and-aria/and removed the corresponding/guides/...redirect.
Comments suppressed due to low confidence (1)
redirects.json:1066
- The PR description/title are about removing redirects for skeleton components, but this hunk also changes the
/accessibility/semantic-htmlredirect target and removes the/guides/accessibility/semantic-htmlredirect. If this is intentional, it would be helpful to call it out in the PR description (or split into a separate PR) so reviewers can assess the risk/intent separately.
"name": "Redirect /accessibility/semantic-html to /accessibility/design-guidance/semantic-html-and-aria",
"match": "^accessibility/semantic-html/?$",
"destination": "/accessibility/design-guidance/semantic-html-and-aria/"
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "name": "Redirect /components to /product/components", | ||
| "match": "^components/?$", | ||
| "destination": "/product/components/" | ||
| }, | ||
| { | ||
| "name": "Redirect /components/skeleton-*/figma to /products/components/skeleton-loaders/", | ||
| "match": "^components/skeleton-(.*)/figma/?", | ||
| "destination": "/product/components/skeleton-loaders/" | ||
| }, | ||
| { | ||
| "name": "Redirect /components/skeleton-* to /products/components/skeleton-loaders", | ||
| "match": "^components/skeleton-(.+)", | ||
| "destination": "/product/components/skeleton-loaders" | ||
| }, | ||
| { | ||
| "name": "Redirect /components/selectpanel/react/* to /product/components/select-panel/", | ||
| "match": "^components/selectpanel/react", |
There was a problem hiding this comment.
This PR removes the /components/skeleton-* and /components/skeleton-*/figma redirect rules. After this change those legacy URLs will no longer be redirected by web.config, so they will 404 unless the site serves them natively. Please confirm the corresponding native routes exist (including the /figma variant if still referenced) or keep a redirect in place until all callers/links are updated.
There was a problem hiding this comment.
The native routes are being added in a PR in a different repo.
2 participants
Removes the dns redirects for skeleton loaders so they are loaded natively
Related: https://github.com/github/primer-docs/pull/897