Skip to content

Conversation

@rezrah
Copy link
Collaborator

@rezrah rezrah commented Jan 19, 2026

Summary

Towards https://github.com/github/brand-marketing-design/issues/2674

Updates the Octicons package, which contains updates to the GitHub brand logo.

List of notable changes:

  • Update Octicons
  • Regen snapshots
  • Increased timeouts on IDE tests, these are unrelated and failing on main too (no idea why 🤷)

Steps to test:

  1. Review storybook and docs, ensure that logos are appearing correctly everywhere

Contributor checklist:

  • All new and existing CI checks pass
  • Tests prove that the feature works and covers both happy and unhappy paths
  • Any drop in coverage, breaking changes or regressions have been documented above
  • UI Changes contain new visual snapshots (generated by adding update snapshots label to the PR)
  • All developer debugging and non-functional logging has been removed
  • Related issues have been referenced in the PR description

Reviewer checklist:

  • Check that pull request and proposed changes adhere to our contribution guidelines and code of conduct
  • Check that tests prove the feature works and covers both happy and unhappy paths
  • Check that there aren't other open Pull Requests for the same update/change

Screenshots:

Please try to provide before and after screenshots or videos

Before After
Screenshot 2026-01-19 at 15 39 56 Screenshot 2026-01-19 at 15 40 03
Before After
Screenshot 2026-01-19 at 15 43 52 Screenshot 2026-01-19 at 15 43 42

@rezrah rezrah requested a review from a team as a code owner January 19, 2026 15:44
Copilot AI review requested due to automatic review settings January 19, 2026 15:44
@changeset-bot
Copy link

changeset-bot bot commented Jan 19, 2026

🦋 Changeset detected

Latest commit: e376b42

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
@primer/react-brand Patch
@primer/brand-docs Patch
@primer/brand-css Patch
@primer/brand-primitives Patch
@primer/brand-e2e Patch
@primer/brand-fonts Patch
@primer/brand-config Patch
@primer/brand-storybook Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Jan 19, 2026

🟢 No design token changes found

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request updates the @primer/octicons-react package from version 19.15.1 to 19.21.2, which includes updates to the GitHub brand logo as referenced in the linked Octicons PR.

Changes:

  • Updated @primer/octicons-react dependency from 19.15.1 to 19.21.2 in package.json files
  • Regenerated visual regression test snapshots for MinimalFooter component to reflect logo changes
  • Updated package-lock.json with new package resolution and integrity hashes

Reviewed changes

Copilot reviewed 2 out of 15 changed files in this pull request and generated no comments.

File Description
packages/react/package.json Updated octicons-react devDependency to 19.21.2
apps/next-docs/package.json Updated octicons-react dependency to 19.21.2
package-lock.json Updated package resolutions, added integrity hashes, and inadvertently changed Node version requirements
MinimalFooter visual snapshots (5 files) Regenerated snapshots reflecting updated GitHub logo from Octicons update

@rezrah rezrah requested a review from danielguillan January 19, 2026 15:47
@github-actions
Copy link
Contributor

github-actions bot commented Jan 19, 2026

🟢 Unit test coverage changes found

Unit test coverage has been updated through this PR.

Changes: 0 new tests, 0 removed tests, 1 improved, 0 decreased

Component/Hook Statements Functions Branches Change
IDE 89.2% 91.0% 97.6% 80.8% 82.8% +2.0%

@github-actions
Copy link
Contributor

github-actions bot commented Jan 19, 2026

🟢 No visual differences found

Our visual comparison tests did not find any differences in the UI.

@rezrah rezrah changed the title update octicons package Update GitHub icons and logos Jan 19, 2026
Copy link
Contributor

@danielguillan danielguillan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rezrah rezrah merged commit 4733b38 into main Jan 20, 2026
23 of 24 checks passed
@rezrah rezrah deleted the rezrah/upgrade-octicons branch January 20, 2026 10:34
@primer primer bot mentioned this pull request Jan 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants