-
Notifications
You must be signed in to change notification settings - Fork 60
Update GitHub icons and logos #1227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: e376b42 The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
🟢 No design token changes found |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request updates the @primer/octicons-react package from version 19.15.1 to 19.21.2, which includes updates to the GitHub brand logo as referenced in the linked Octicons PR.
Changes:
- Updated
@primer/octicons-reactdependency from 19.15.1 to 19.21.2 in package.json files - Regenerated visual regression test snapshots for MinimalFooter component to reflect logo changes
- Updated package-lock.json with new package resolution and integrity hashes
Reviewed changes
Copilot reviewed 2 out of 15 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/react/package.json | Updated octicons-react devDependency to 19.21.2 |
| apps/next-docs/package.json | Updated octicons-react dependency to 19.21.2 |
| package-lock.json | Updated package resolutions, added integrity hashes, and inadvertently changed Node version requirements |
| MinimalFooter visual snapshots (5 files) | Regenerated snapshots reflecting updated GitHub logo from Octicons update |
🟢 Unit test coverage changes foundUnit test coverage has been updated through this PR. Changes: 0 new tests, 0 removed tests, 1 improved, 0 decreased
|
🟢 No visual differences foundOur visual comparison tests did not find any differences in the UI. |
danielguillan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Summary
Towards https://github.com/github/brand-marketing-design/issues/2674
Updates the Octicons package, which contains updates to the GitHub brand logo.
List of notable changes:
maintoo (no idea why 🤷)Steps to test:
Contributor checklist:
update snapshotslabel to the PR)Reviewer checklist:
Screenshots: