Skip to content

Conversation

@rezrah
Copy link
Collaborator

@rezrah rezrah commented Jan 19, 2026

Summary

Updates Node.js to v24 across the repo, which was recently give LTS status.

Contributor checklist:

  • All new and existing CI checks pass
  • Tests prove that the feature works and covers both happy and unhappy paths
  • Any drop in coverage, breaking changes or regressions have been documented above
  • UI Changes contain new visual snapshots (generated by adding update snapshots label to the PR)
  • All developer debugging and non-functional logging has been removed
  • Related issues have been referenced in the PR description

Reviewer checklist:

  • Check that pull request and proposed changes adhere to our contribution guidelines and code of conduct
  • Check that tests prove the feature works and covers both happy and unhappy paths
  • Check that there aren't other open Pull Requests for the same update/change

Screenshots:

Please try to provide before and after screenshots or videos

Before After

@rezrah rezrah requested a review from a team as a code owner January 19, 2026 14:26
Copilot AI review requested due to automatic review settings January 19, 2026 14:26
@changeset-bot
Copy link

changeset-bot bot commented Jan 19, 2026

🦋 Changeset detected

Latest commit: 5ccfba3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
@primer/react-brand Minor
@primer/brand-primitives Minor
@primer/brand-css Minor
@primer/brand-docs Minor
@primer/brand-e2e Minor
@primer/brand-fonts Minor
@primer/brand-config Minor
@primer/brand-storybook Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@rezrah rezrah changed the title upgrade Node to v24 (promoted to LTS) Upgrade Node to v24 (LTS) Jan 19, 2026
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR upgrades Node.js from v22 to v24 across the repository, including package dependencies, GitHub Actions workflows, and development container configurations.

Changes:

  • Updated @types/node dependency from 22.18.1 to 24.10.9
  • Updated minimum Node.js engine requirement from >=22.0.0 to >=24.0.0
  • Updated node-version in all GitHub Actions workflows from 22 to 24
  • Updated devcontainer image from typescript-node:22 to typescript-node:24

Reviewed changes

Copilot reviewed 16 out of 17 changed files in this pull request and generated no comments.

Show a summary per file
File Description
package.json Updated @types/node to v24.10.9 and engines.node to >=24.0.0
.github/workflows/ci.yml Updated node-version to 24 for CI workflow
.github/workflows/deploy_docs.yml Updated node-version to 24 for docs deployment
.github/workflows/deploy_docs_preview.yml Updated node-version to 24 for preview deployments
.github/workflows/deploy_docs_preview_forks.yml Updated node-version to 24 for fork preview deployments
.github/workflows/figma_connect_publish.yml Updated node-version to 24 for Figma Connect publishing
.github/workflows/integration_test_astro.yml Updated node-version to 24 for Astro integration tests
.github/workflows/integration_test_nextjs.yml Updated node-version to 24 for Next.js integration tests
.github/workflows/integration_test_remix.yml Updated node-version to 24 for Remix integration tests
.github/workflows/release_candidate_checklist.yml Updated node-version to 24 for release candidate workflow
.github/workflows/ui_test_accessibility.yml Updated node-version to 24 for accessibility tests
.github/workflows/ui_test_diff_comment.yml Updated node-version to 24 for UI diff commenting
.github/workflows/ui_test_primitives_diff.yml Updated node-version to 24 for primitives diff tests
.github/workflows/update_visual_snapshots.yml Updated node-version to 24 for visual snapshot updates
.github/workflows/visual_test_storybook.yml Updated node-version to 24 for Storybook visual tests
.devcontainer/devcontainer.json Updated devcontainer image to typescript-node:24

@github-actions
Copy link
Contributor

github-actions bot commented Jan 19, 2026

🟢 No design token changes found

@github-actions
Copy link
Contributor

github-actions bot commented Jan 19, 2026

🟢 No unit test coverage changes found

All components and hooks with tests maintain the same coverage as the main branch.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 19, 2026

🟢 No visual differences found

Our visual comparison tests did not find any differences in the UI.

Copy link
Contributor

@danielguillan danielguillan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@rezrah rezrah merged commit a1caad6 into main Jan 19, 2026
23 checks passed
@rezrah rezrah deleted the rezrah/update-node-lts branch January 19, 2026 15:25
@primer primer bot mentioned this pull request Jan 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants