Skip to content

Conversation

@frankc95
Copy link

No description provided.

@bbucek
Copy link
Contributor

bbucek commented May 30, 2023

Cards:

  • Labels lack colours
  • Image hover effect doesn't work on the whole card

CTA:

  • Responds nicely
  • No cursor pointer on the button

@rafzielinski
Copy link
Collaborator

Hi and thank you for your submission.
We like your implementation but we want to ask for few tweaks before we get to the final decision.

  1. Button is missing an arrow, also, usually it should be an anchor link instead of the button element
  2. Cards are not animating when hovering over the text.
  3. Card label styling is incomplete.
  4. Classes on CTA are a bit messy, I wouldn't personally use classes from different element as this might generate some unwanted styling when original element styling is changed. If you want to re-use styling from other element I'd advice using SASS's @extend function.

@frankc95
Copy link
Author

frankc95 commented Jun 1, 2023

Hi all,

Thank for getting back to me and your feedback.

The first time round I couldn't access the design file and only the preview (2nd link).
I couldn't locate a chevron icon in the repo. Previously, I used font-awesome icon, however, this time I managed to access the design file and I exported the chevron icon from there.

Please, let me know if the changes I've made are satisfactory.

Kind regards,
Jakub

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants