Test Complete #4
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
The CTA is entirely different compared to the design. However, it looks decent. The biggest problem with the accessibility when the image loaded is on the light. Some redundant HTML elements in the build Card image proportions are distorted when changing screen size. |
Author
|
Hi Bart, The CTA is entirely different compared to the design. However, it looks decent. The biggest problem with the accessibility when the image loaded is on the light. I must have misunderstood the brief as I thought we had creative freedom on the CTA so I do apologise. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Bart,
I have completed the test task and I look forward to any feedback you may provide.
Kind regards