Skip to content

Conversation

@einc123
Copy link

@einc123 einc123 commented May 16, 2023

No description provided.

@bbucek
Copy link
Contributor

bbucek commented May 30, 2023

Overall pretty good desktop build.

  • Some minor issues with card hover (border-radius lost, only scales image on top part hover)
  • Tags on cards don't have the correct colours
  • Needs some breakpoint tweaks (cards squished too much)

CTA is not responsive (the button should drop below text on smaller screens), and there are some text alignment issues with the button and header. Maybe a slightly different HTML structure would be better.

@rafzielinski
Copy link
Collaborator

Hi and thank you for your submission.
We like your implementation but we want to ask for few tweaks before we get to the final decision.

  1. Border radius is disappearing on hover
  2. When hovered over text on card, card is not animated
  3. Labels are missing color variants
  4. Cards are a bit squished ~1002px
  5. CTA button missing an icon, also it should be aligned to the top of the title and should be handled correctly on mobile screen.

@einc123
Copy link
Author

einc123 commented May 31, 2023

Hi, Thanks for the feedback,
I will make those changes soon!

Thanks,
Euan

@einc123
Copy link
Author

einc123 commented May 31, 2023

Hi again,
Made those changes.

Thanks,
Euan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants