Skip to content

Conversation

@jithamolns
Copy link

Task completed.

@bbucek
Copy link
Contributor

bbucek commented May 30, 2023

Cards:

  • Good responsive, but could use and extra breakpoint

CTA:

  • Pretty good work

Overall:

  • Could be done without Bootstrap

@rafzielinski
Copy link
Collaborator

rafzielinski commented May 31, 2023

Hi and thank you for your submission.
We like your implementation but we want to ask for few tweaks before we get to the final decision.

  1. Button could use some hover state.
  2. We don't use Bootstrap in our work, it would be nice to see this task done without it so we can have a better overview on your flex-box/grid skills
  3. Note: When you've changed our project structure you've removed node_modules entry from the .gitignore. Remember to keep it in this file as it helps with running project and saves a lot of space.

@jithamolns
Copy link
Author

Thank you for the feedback, get back to you soon.

@jithamolns
Copy link
Author

I have created a new branch that resolves the feedback. Please review the new branch jithamolns:revised-task

Thanks and Regards,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants