Skip to content

Conversation

@chusarublessing
Copy link

No description provided.

@bbucek
Copy link
Contributor

bbucek commented May 30, 2023

Cards:

  • Good responsive, although could have one more break with two cards
  • No hover state
  • No coloured labels

CTA:

  • Text could span the whole width when on mobile
  • Could use icon instead of text for chevron

@rafzielinski
Copy link
Collaborator

Hi and thank you for your submission.
We like your implementation but we want to ask for few tweaks before we get to the final decision.

  1. CTA button should have an icon instead of text chevron, it's also missing a hover state.
  2. CTA text, try using max-width with rem value instead of width: 50% to limit text width.
  3. Card is missing a hover state.
  4. Card label is missing color variants
  5. Listing could display cards on different screen sizes like 3 > 2 > 1 instead of jumping straight from 3 to 1.

@chusarublessing
Copy link
Author

chusarublessing commented May 31, 2023 via email

@chusarublessing
Copy link
Author

Hie Rafzielinski

I have implemented changes as advised.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants