Skip to content

Conversation

@shawnanuptra
Copy link

My submission for the test! Feel free to contact me with any issues or feedback :)

@bbucek
Copy link
Contributor

bbucek commented May 30, 2023

CTA:

  • Vertical spacing could be better, but overall pretty good
  • Button not aligned with text as per the design on desktop (small tweak in CSS)

Cards:

  • Responsiveness could be better - flexible rather than fixed widths

@rafzielinski
Copy link
Collaborator

Hi and thank you for your submission.
We like your implementation but we want to ask for few tweaks before we get to the final decision.

  1. CTA button should be aligned with the title,
  2. CTA on mobile is missing spacing between the elements
  3. When changing screen size, listing cards should grow, not the spacing between them.

Shawn Martin added 3 commits June 1, 2023 10:00
- changing screen size, card size grows, not spacing
- added  'smaller' and 'tablet' breakpoint
- changed breakpoint names:
-> medium to large
-> small to medium
@shawnanuptra
Copy link
Author

Fixes have been applied based on the feedback given before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants