Skip to content

Conversation

@WwLuo-1024
Copy link

@WwLuo-1024 WwLuo-1024 commented May 20, 2023

😄Thank you so much for giving me this chance to participate in this task. This project has allowed me to apply my knowledge and reach out to some new techniques in SCSS, further enhancing my proficiency in this area. Throughout the project, I have essentially referred to the design in Figma and added the corresponding icons.

  • 1. Styled the cards' component
  • 2. Created and styled another one for the simple 'Call to Action' based on the structure and naming convention of the 'Cards' component

Figure 1. Demo

The hands-on experience gained from working on the project has been invaluable. Please let me know if you have any further feedback on my submission and reach me at wangluocn@outlook.com. Many thanks again.

@bbucek
Copy link
Contributor

bbucek commented May 30, 2023

CTA:

  • Not responsive

Cards:

  • Responsive could be better - cards should flex width

Overall:

  • Good use of predefined code but shouldn't copy CSS from Figma directly for everything

@rafzielinski
Copy link
Collaborator

Hi and thank you for your submission.
We like your implementation but we want to ask for few tweaks before we get to the final decision.

  1. There is no responsiveness in any element and cards are broken on the mobile.
  2. Cards should have a consistent spacing around them
  3. CTA button needs to be handled for mobile screens, it can't stay in the same line as the title.

@WwLuo-1024
Copy link
Author

Thank you so much for the feedback you provided. I've just fixed the issue in my project following your description and feedback and completed a new commit. To be specific, regarding responsive display issues with tablets, desktops etc. and the grid distance between cards. I apologise that my project had the above issues and bugs before the first complete submission was completed.

Please feel free to contact me if there is still additional coding that needs to be modified or if any issues exist. Many thanks again for your time and patience.

Hi and thank you for your submission. We like your implementation but we want to ask for few tweaks before we get to the final decision.

  1. There is no responsiveness in any element and cards are broken on the mobile.
  2. Cards should have a consistent spacing around them
  3. CTA button needs to be handled for mobile screens, it can't stay in the same line as the title.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants