Skip to content

Enhancement : Unify time units display (2 digits) #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nvshah wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Enhancement : Unify time units display (2 digits) #19

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions lib/src/fullscreen_player.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,8 @@ class _FullscreenPlayerState extends State<FullscreenPlayer> {
double doubleTapLWidthFS = 700;
double doubleTapLHeightFS = 400;

String _asTwoDigits(int n) => n?.toString()?.padLeft(2, '0') ?? '';

@override
void initState() {
//Инициализация контроллеров видео при получении данных из Vimeo
Expand Down Expand Up @@ -394,10 +396,9 @@ class _FullscreenPlayerState extends State<FullscreenPlayer> {
Container(
width: 46,
alignment: Alignment(0, 0),
child: Text(value.position.inMinutes.toString() +
':' +
(value.position.inSeconds - value.position.inMinutes * 60)
.toString()),
child: Text(
'${_asTwoDigits(value.position.inMinutes)}:${_asTwoDigits(value.position.inSeconds - value.position.inMinutes * 60)}',
),
),
Container(
height: 20,
Expand All @@ -416,10 +417,9 @@ class _FullscreenPlayerState extends State<FullscreenPlayer> {
Container(
width: 46,
alignment: Alignment(0, 0),
child: Text(value.duration.inMinutes.toString() +
':' +
(value.duration.inSeconds - value.duration.inMinutes * 60)
.toString()),
child: Text(
'${_asTwoDigits(value.duration.inMinutes)}:${_asTwoDigits(value.duration.inSeconds - value.duration.inMinutes * 60)}',
),
),
],
);
Expand Down
17 changes: 8 additions & 9 deletions lib/vimeoplayer.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -408,11 +408,9 @@ class _VimeoPlayerState extends State<VimeoPlayer> {
Container(
width: 46,
alignment: Alignment(0, 0),
child: Text(value.position.inMinutes.toString() +
':' +
(value.position.inSeconds - value.position.inMinutes * 60)
.toString()),
),
child: Text(
'${_asTwoDigits(value.position.inMinutes)}:${_asTwoDigits(value.position.inSeconds - value.position.inMinutes * 60)}',
),
Container(
height: 20,
width: videoWidth - 92,
Expand All @@ -430,10 +428,9 @@ class _VimeoPlayerState extends State<VimeoPlayer> {
Container(
width: 46,
alignment: Alignment(0, 0),
child: Text(value.duration.inMinutes.toString() +
':' +
(value.duration.inSeconds - value.duration.inMinutes * 60)
.toString()),
child: Text(
'${_asTwoDigits(value.duration.inMinutes)}:${_asTwoDigits(value.duration.inSeconds - value.duration.inMinutes * 60)}',
),
),
],
);
Expand All @@ -444,6 +441,8 @@ class _VimeoPlayerState extends State<VimeoPlayer> {
);
}

String _asTwoDigits(int n) => n?.toString()?.padLeft(2, '0') ?? '';

@override
void dispose() {
_controller.dispose();
Expand Down