Skip to content

fix: make purchase order non-mandatory in matching dialog #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pritambiswal merged 3 commits into from
Feb 4, 2026
Merged

fix: make purchase order non-mandatory in matching dialog #34

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
aad504e
fix: make purchase order non-mandatory in matching dialog
Feb 2, 2026
6edee8d
fix: add apt_packages.txt for lxml build dependencies
Feb 4, 2026
d64eb5b
fix: enforce
Feb 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions apt_packages.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
libxml2-dev
libxslt-dev
1 change: 1 addition & 0 deletions edocument/edocument/doctype/edocument/edocument.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,6 +135,7 @@ function show_matching_dialog(frm, matching_data, config) {
function save_matching(frm, dialog, original_data) {
const data = JSON.parse(JSON.stringify(original_data));
const values = dialog.get_values();
if (!values) return; // Validation failed

// Update supplier
if (data.supplier) {
Expand Down
1 change: 0 additions & 1 deletion edocument/edocument/profiles/peppol/matcher.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -530,7 +530,6 @@ def _get_dialog_config(matching_data: dict) -> dict:
"fieldname": "purchase_order",
"label": _("Match to Purchase Order"),
"options": "Purchase Order",
"reqd": 1,
"default": po_data.get("matched"),
}
)
Expand Down