Skip to content

SDK-4415 Add changes to send extra details for app-accessibility session#3

Open
pri-gadhiya wants to merge 5 commits intov8from
SDK-4415-wdio-central-auth-v2
Open

SDK-4415 Add changes to send extra details for app-accessibility session#3
pri-gadhiya wants to merge 5 commits intov8from
SDK-4415-wdio-central-auth-v2

Conversation

@pri-gadhiya
Copy link
Copy Markdown
Owner

Proposed changes

As central auth Phase 2 we want to add central token to app accessibility session

Types of changes

  • Polish (an improvement for an existing feature)
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (improvements to the project's docs)
  • Specification changes (updates to WebDriver command specifications)
  • Internal updates (everything related to internal scripts, governance documentation and CI files)

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Backport Request

//: # (The current main branch is the development branch for WebdriverIO v9. If your change should be released to the current major version of WebdriverIO (v8), please raise another PR with the same changes against the v8 branch.)

  • This change is solely for v9 and doesn't need to be back-ported
  • Back-ported PR at #XXXXX

Further comments

Reviewers: @webdriverio/project-committers

mergedParams.centralAuthHeader = centralAuthConfig.centralAuthHeader
mergedParams.centralAuthToken = centralAuthConfig.centralAuthToken
// Remove centralAuthToken from mergedParams after use
delete mergedParams.centralAuthToken
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is it being deleted immediately ?

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is by mistake added, will remove it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants