Add handledRequests, passthroughRequests & unhandledRequests to ts def#353
Open
abel-n wants to merge 1 commit intopretenderjs:masterfrom
Open
Add handledRequests, passthroughRequests & unhandledRequests to ts def#353abel-n wants to merge 1 commit intopretenderjs:masterfrom
abel-n wants to merge 1 commit intopretenderjs:masterfrom
Conversation
|
Any chance this will be merged soon? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #337
Moving our project to typescript I've bumped into an issue that's been there for a long time apparently: missing handled / unhandled / passthrough request information from the typescript definition.
I can see that the actual value might be an instance of☺️
NoopArray, but type-wise I think it should be safe to just stick to using an array of requests. Suggestions are welcome.