Open
Conversation
Member
|
Thanks for adding Prettier! Can you also add a precommit hook to prettify code? https://prettier.io/docs/en/precommit.html |
Contributor
Author
|
We were exploring adding this to Mirage, but I got some negative feedback (see https://twitter.com/ryantotweets/status/1203065809167409154). I'm not sure if it's worth adding. I can add the prettier check to CI so we can failures if someone opens a PR with unformatted code. How does that sound? |
Member
|
Pretender doesn't run lint in ci now, I think adding prettier eslint integration and make it easier to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.