Add a build step and produce ES6 files.#240
Closed
givanse wants to merge 10 commits intopretenderjs:masterfrom
Closed
Add a build step and produce ES6 files.#240givanse wants to merge 10 commits intopretenderjs:masterfrom
givanse wants to merge 10 commits intopretenderjs:masterfrom
Conversation
givanse
commented
Dec 30, 2018
| { | ||
| "name": "pretender", | ||
| "version": "2.1.0", | ||
| "version": "3.1.0", |
Contributor
Author
There was a problem hiding this comment.
Took the liberty of bumping the version number since this is a fairly large change to the code base.
givanse
commented
Dec 30, 2018
| * fullpath: '/mypage?test=yes' | ||
| * } | ||
| */ | ||
| function parseURL(url: string) { |
givanse
commented
Jan 2, 2019
| @@ -0,0 +1,48 @@ | |||
| import PretenderES from '../src/pretender.es'; | |||
Contributor
Author
There was a problem hiding this comment.
Pretender imported as a ES6 module. Also not that this test file is a ts file.
givanse
commented
Jan 2, 2019
| const server = new Pretender(function() {}); | ||
| ``` | ||
|
|
||
| Full example: [use-pretender-as-a-module](https://github.com/givanse/use-pretender-as-a-module) |
Contributor
Author
There was a problem hiding this comment.
For the repo linked here, I added as collaborators the people that have merge access to Pretender.
Or if you prefer me to delete the mention of 'use-pretender-as-a-module', that is fine, I will.
Member
|
Is there any reason why all of these
must be included in a single PR? I could see this being at least 4
This also has the potential to be a minor release. |
Contributor
Author
|
you are right, this got too messy, I'll split it up |
Contributor
Author
|
PR #243
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PRs does the following:
pretender.js=>src/index.tspretender.js- this is the IIFE version, it should be working the same as beforepretender.es.js- this one is newmoduleattribute FakeXMLHttpRequest#46I'm still testing this with an actual app, but I think its ready to get reviewed and get a conversation started.done with thatyarn link pretender)