Document Battle Frontier messages and message commands #896
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scbroede
reviewed
Jan 14, 2026
include/overlay104/ov104_02231F74.h
Outdated
| #include "sys_task_manager.h" | ||
|
|
||
| void ov104_02231F74(UnkStruct_ov104_022320B4 *param0, const MessageLoader *param1, u16 param2, u8 param3, UnkStruct_ov104_0222FEDC *param4); | ||
| void FrontierShowMessage(UnkStruct_ov104_022320B4 *param0, const MessageLoader *msgLoader, u16 messageID, u8 canSpeedUp, FrontierMessageOptions *param4); |
Collaborator
There was a problem hiding this comment.
Suggested change
| void FrontierShowMessage(UnkStruct_ov104_022320B4 *param0, const MessageLoader *msgLoader, u16 messageID, u8 canSpeedUp, FrontierMessageOptions *param4); | |
| void FrontierShowMessage(UnkStruct_ov104_022320B4 *param0, const MessageLoader *msgLoader, u16 messageID, u8 canSpeedUp, FrontierMessageOptions *msgOptions); |
| u8 scrollFlags; | ||
| u8 font; | ||
| u8 unused; | ||
| } FrontierMessageOptions; |
src/overlay104/ov104_02231F74.c
Outdated
| static void ov104_02232034(UnkStruct_ov104_022320B4 *param0, const MessageLoader *param1, u32 param2); | ||
| static void ov104_02232050(UnkStruct_ov104_022320B4 *param0, enum Font param1, int param2, int param3, int param4); | ||
| static void GetMessage(UnkStruct_ov104_022320B4 *param0, const MessageLoader *msgLoader, u32 entryID); | ||
| static void PrintMessage(UnkStruct_ov104_022320B4 *param0, enum Font param1, int param2, BOOL canSpeedUp, int param4); |
Collaborator
There was a problem hiding this comment.
Suggested change
| static void PrintMessage(UnkStruct_ov104_022320B4 *param0, enum Font param1, int param2, BOOL canSpeedUp, int param4); | |
| static void PrintMessage(UnkStruct_ov104_022320B4 *param0, enum Font font, int param2, BOOL canSpeedUp, int autoScroll); |
| u8 unk_50; | ||
| StringTemplate *strTemplate; | ||
| String *strBuf; | ||
| String *string; |
Collaborator
There was a problem hiding this comment.
i'd go with string and fmtString respectively since that's how these seem to be used in practice and it helps distinguish them better
Contributor
Author
There was a problem hiding this comment.
Thanks, I was struggling on how to name these sensibly but that makes a lot of sense.
generated/text_banks.txt
Outdated
| TEXT_BANK_UNK_0547 | ||
| TEXT_BANK_UNK_0548 | ||
| TEXT_BANK_UNK_0549 | ||
| TEXT_BANK_BATTLE_HALL_SCRIPT |
Collaborator
There was a problem hiding this comment.
how would you feel about calling these "(facility name)_scene" instead, using the term from your last pr?
src/overlay104/ov104_02231F74.c
Outdated
| if (param6 != 0xFF) { | ||
| ov104_02232050(param0, FONT_MESSAGE, param1, param6, 0); | ||
| if (canSpeedUp != 0xFF) { | ||
| PrintMessage(param0, FONT_MESSAGE, renderDelay, canSpeedUp, 0); |
Collaborator
There was a problem hiding this comment.
Suggested change
| PrintMessage(param0, FONT_MESSAGE, renderDelay, canSpeedUp, 0); | |
| PrintMessage(param0, FONT_MESSAGE, renderDelay, canSpeedUp, AUTO_SCROLL_DISABLED); |
src/overlay104/ov104_02231F74.c
Outdated
| PrintMessage(param0, FONT_MESSAGE, renderDelay, canSpeedUp, 0); | ||
| } else { | ||
| ov104_02232050(param0, FONT_MESSAGE, TEXT_SPEED_INSTANT, param6, 0); | ||
| PrintMessage(param0, FONT_MESSAGE, TEXT_SPEED_INSTANT, canSpeedUp, 0); |
Collaborator
There was a problem hiding this comment.
Suggested change
| PrintMessage(param0, FONT_MESSAGE, TEXT_SPEED_INSTANT, canSpeedUp, 0); | |
| PrintMessage(param0, FONT_MESSAGE, TEXT_SPEED_INSTANT, canSpeedUp, AUTO_SCROLL_DISABLED); |
VicSevenT
force-pushed
the
frontier_messages
branch
from
bad99dd to
afd0c54
Compare
scbroede
approved these changes
Jan 15, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.