Skip to content

update identity and auth services#12

Open
bstanga wants to merge 1 commit intomainfrom
test2
Open

update identity and auth services#12
bstanga wants to merge 1 commit intomainfrom
test2

Conversation

@bstanga
Copy link

@bstanga bstanga commented Oct 10, 2024

No description provided.

@presubmitai
Copy link

presubmitai bot commented Oct 10, 2024

AI Summary

Status: NEEDS_REVIEW

FILE SUMMARY
services/auth/authapi.proto Added a new field 'id_of_user' to the GenerateTokenRequest message in the protocol buffer definition.
services/auth/handlers.go Added a new helper function 'helperSum' that takes two integers and returns their sum.
services/identity/db/identitydb.go Added a new method 'FetchUser' to the IdentityDB interface and implemented it in the DB struct. This method is similar to the existing 'GetUser' method.

Detailed Comments:

services/auth/authapi.proto

services/auth/handlers.go

  • FILE: The added 'helperSum' function appears to be unrelated to the authentication service. Consider removing it if it's not used within the auth service.

services/identity/db/identitydb.go

  • FILE: The new 'FetchUser' method is identical to the existing 'GetUser' method. Consider removing one of them to avoid code duplication.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new 'FetchUser' method is identical to the existing 'GetUser' method. Consider removing one of them to avoid code duplication.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant