Fix incorrect cache variable name preventing proper page cache ... #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iable name because it isn't set or used anywhere. This bug prevents Drupal from enforcing minimum cache_lifetime for pages.
Author
There was a problem hiding this comment.
page_cache_lifetime variable isn't anywhere in pressflow code.
rjbrown99
added a commit
to rjbrown99/6
that referenced
this pull request
May 1, 2012
|
This is still not included in the latest release, please fix it, we shouldn't have to be patching old websites like this. |
|
The lack of this fix has caused even more confusion: https://drupal.org/node/2130865 |
|
This fix is not complete. $expire is a timestamp not a TTL. Here is a proper working patch: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix incorrect cache variable name. page_cache_lifetime is invalid variable name because it isn't set or used anywhere. This bug prevents Drupal from enforcing minimum cache_lifetime for pages. Without this change, even if Minimum cache lifetime (Settings->Performance) is set to 1 minute, page will still be cached for CACHE_TEMPORARY.