Refactor lookup benchmark implementations using AbstractLookup base class#4
Merged
samuelstanton merged 4 commits intomainfrom Mar 30, 2025
Merged
Refactor lookup benchmark implementations using AbstractLookup base class#4samuelstanton merged 4 commits intomainfrom
samuelstanton merged 4 commits intomainfrom
Conversation
- Update URLs to raw.githubusercontent.com - Add alphabet_size attribute for test compatibility - Fix type issues with optimal_value to ensure it's a float - Ensure all lookups can properly download data via pooch All tests now pass and benchmarks can be successfully run.
…lass - Create AbstractLookup base class to improve code reuse and maintainability - Update TFBIND8, TrpB, and DHFR implementations to use AbstractLookup - Standardize naming conventions across all implementations (alphabet, _lookup_dict) - Update tests to use consistent attribute names - All tests and benchmarks now pass with cleaner, more maintainable code
- Create mock implementations of TFBIND8, TrpB, and DHFR for CI testing - Use synthetic data in CI environments to avoid network issues - Maintain real data loading for local development - All tests continue to pass locally
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves the organization and maintainability of the lookup-based benchmark functions by introducing an
AbstractLookup base class that provides shared functionality. This reduces code duplication across the
TFBIND8, TrpB, and DHFR implementations while standardizing naming conventions and interfaces.
Key changes:
Benefits include reduced code redundancy, improved code reuse, and easier maintenance when adding new
lookup-based benchmarks in the future.