Skip to content

build: better linting command-line(s) in stavefile.go #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
preminger merged 1 commit into from
Jan 8, 2026
Merged

build: better linting command-line(s) in stavefile.go #98

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,14 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

## [0.17.11] - 2026-01-08

### Changed

- "Double-dip" running of `golangci-lint` in stavefile.go: run once with `--fix` & without reporting exit code, then run a second time without `--fix` & report exit code as well as any output.

- Bumped `stave` to `v0.9.5`.

## [0.17.10] - 2026-01-07

### Changed
Expand Down Expand Up @@ -472,7 +480,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [0.4.0] - 2025-10-30

[unreleased]: https://github.com/preminger/goctx/compare/v0.17.10...HEAD
[unreleased]: https://github.com/preminger/goctx/compare/v0.17.11...HEAD
[0.17.11]: https://github.com/preminger/goctx/compare/v0.17.10...v0.17.11
[0.17.10]: https://github.com/preminger/goctx/compare/v0.17.9...v0.17.10
[0.17.9]: https://github.com/preminger/goctx/compare/v0.17.8...v0.17.9
[0.17.8]: https://github.com/preminger/goctx/compare/v0.17.7...v0.17.8
Expand Down
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ require (
github.com/sebdah/goldie/v2 v2.8.0
github.com/spf13/cobra v1.10.2
github.com/stretchr/testify v1.11.1
github.com/yaklabco/stave v0.9.4
github.com/yaklabco/stave v0.9.5
golang.org/x/tools v0.40.0
)

Expand Down
4 changes: 2 additions & 2 deletions go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,8 +145,8 @@ github.com/xo/terminfo v0.0.0-20220910002029-abceb7e1c41e h1:JVG44RsyaB9T2KIHavM
github.com/xo/terminfo v0.0.0-20220910002029-abceb7e1c41e/go.mod h1:RbqR21r5mrJuqunuUZ/Dhy/avygyECGrLceyNeo4LiM=
github.com/yaklabco/direnv/v2 v2.37.2-0.20260103155829-e362a6bcef30 h1:75OkK0/2gGInt4i9h2XRUN/7Phtu6Nq9oxuFCZKtvug=
github.com/yaklabco/direnv/v2 v2.37.2-0.20260103155829-e362a6bcef30/go.mod h1:1ty/+Bkj+xVwSri8uDCsOzp15bC9MIzjyWvp6zuf+yY=
github.com/yaklabco/stave v0.9.4 h1:Kq1atetrg7Kk/aCFpwdc6ALfQGFXwHJR+r9p1cKV2DA=
github.com/yaklabco/stave v0.9.4/go.mod h1:GAPyyyPA4M/5qkPvfbB4R8ZJw6ftk05wqWVj5aUBoI8=
github.com/yaklabco/stave v0.9.5 h1:dJZFgHj76r+RqyBKJ04PCX2FvvJ9k9jb2fNuhi1UhHw=
github.com/yaklabco/stave v0.9.5/go.mod h1:GAPyyyPA4M/5qkPvfbB4R8ZJw6ftk05wqWVj5aUBoI8=
go.yaml.in/yaml/v3 v3.0.4 h1:tfq32ie2Jv2UxXFdLJdh3jXuOzWiL1fo0bu/FbuKpbc=
go.yaml.in/yaml/v3 v3.0.4/go.mod h1:DhzuOOF2ATzADvBadXxruRBLzYTpT36CKvDb3+aBEFg=
golang.org/x/exp v0.0.0-20251209150349-8475f28825e9 h1:MDfG8Cvcqlt9XXrmEiD4epKn7VJHZO84hejP9Jmp0MM=
Expand Down
7 changes: 6 additions & 1 deletion stavefile.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,7 +244,12 @@ func (Lint) Markdown() error {
// Go runs golangci-lint with auto-fix enabled
func (Lint) Go() error {
st.Deps(Init)
out, err := sh.Output("golangci-lint", "run", "--fix", "--allow-parallel-runners", "--build-tags='!ignore'")

args := []string{"run", "--allow-parallel-runners", "--build-tags='!ignore'", "--fix"}

_ = sh.Run("golangci-lint", args...) //nolint:errcheck // Intentional; re-run without `--fix` on next line.

out, err := sh.Output("golangci-lint", lo.Slice(args, 0, len(args)-1)...)
if err != nil {
titleStyle, blockStyle := ui.GetBlockStyles()
outputln(titleStyle.Render("golangci-lint output"))
Expand Down