Implemented Interactive client and still working on pushing books to …#14
Open
Implemented Interactive client and still working on pushing books to …#14
Conversation
premaseem
reviewed
Feb 15, 2017
| * @author Sphoorthi Gaddam | ||
| */ | ||
| public class Book { | ||
| Set<String> books = new HashSet<String>(); |
Owner
There was a problem hiding this comment.
since book is the domain object it should have it property called as name which could be string.
premaseem
reviewed
Feb 15, 2017
| Scanner scan = new Scanner(System.in); | ||
| Book book; | ||
| Student student; | ||
| book = new Book(); |
Owner
There was a problem hiding this comment.
We can do it Book book = new Book()
premaseem
reviewed
Feb 15, 2017
| public class Student { | ||
|
|
||
| Map<String, String> students = new HashMap<String, String>(); | ||
| Book book = new Book(); |
Owner
There was a problem hiding this comment.
This might not be required here since each time a student object is created, it will call book constructor and would create redundant / duplicate books.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…students