PRE-2310: transfer policyID to new registry when registry changes #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
penDerGraft
requested review from
Jesse-Sawa,
balesandrew and
patrickdappollonio
PRE-2310: transfer policyID to new registry when registry changes
🚨 Report Summary
For more details view the full report in OpenZeppelin Code Inspector |
Jesse-Sawa
approved these changes
Dec 3, 2025
patrickdappollonio
approved these changes
Dec 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a potential data synchronization issue when updating a the PredicateRegistry for a PredicateClient contract. Since each client stores the current policyID in memory, switching the registry could create a situation where the client has a stored policy ID but the registry doesn't.
To resolve this,
_setRegistryis now an atomic operation consisting of 1) updating the registry and 2) setting the current policyID on it.