clean up docs, pragma, and events #38
Conversation
penDerGraft
requested review from
Jesse-Sawa,
balesandrew and
patrickdappollonio
|
You have run out of free Bugbot PR reviews for this billing cycle. This will reset on December 4. To receive reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial. |
clean up docs, pragma, and events
🚨 Report Summary
For more details view the full report in OpenZeppelin Code Inspector |
| /// @param policy The policy ID used for validation | ||
| /// @param uuid The unique identifier for the statement | ||
| /// @param expiration The expiration timestamp of the attestation | ||
| event StatementValidated( |
There was a problem hiding this comment.
Scope creep: is the statement or attestation validated?
There was a problem hiding this comment.
Fair point! I'll change it.
There was a problem hiding this comment.
Actually, going to punt on this for now. There are a few other semantic changes that might make sense to make so I'll bundle them together.
| @@ -0,0 +1,4 @@ | |||
| { | |||
| "solidity.compileUsingRemoteVersion": "v0.8.28+commit.c1df9f6f", | |||
| "solidity.defaultCompiler": "remote" | |||
There was a problem hiding this comment.
Yes, actually. When you pin the pragma, the editor could complain if it's not pinned too.
This PR completes several incomplete docstrings, makes pragma references fixed and slightly optimizes events by only emitting when values actually change.