This repository was archived by the owner on Aug 14, 2025. It is now read-only.
Install pip via apt #260
Merged
Install pip via apt #260
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenjaminRodenberg
suggested changes
Dec 17, 2020
Member
BenjaminRodenberg
left a comment
BenjaminRodenberg
left a comment
There was a problem hiding this comment.
Using pip from apt is a good step. However, I have a few minor comments below.
BenjaminRodenberg
added a commit
to precice/python-bindings
that referenced
this pull request
Dec 17, 2020
* Update documentation * Clean up introduction text * Overhaul documentation * Fix errors * Format main readme * Update header * Overhaul trigger_systemtests explanation * Overhaul documentation * Update development.md * Add links to useful docs * Format sections * Overhaul documentation * Update link list * Fix grammar
Co-authored-by: Benjamin Rüth <benjamin.rueth@tum.de>
Eder-K
force-pushed
the
EderK-patch-pip
branch
from
b462ece to
a431b50
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #97.
This changes the
pipinstallation method: we now usepipprovided byapt.Note: the installation of
pipshould occur in the dockerfile that requires it, not in earlier base files. At the moment, onlyfenics-adapterrequirespipto function, so it is the only adapter affected by this change.In Ubuntu 18.04, we have found that the
pipversion provided byaptis too old, therefore we add the following step after installingpip:For context, the discussion below also mentions additional, unrelated changes to the dockerfiles that were initially attached to this PR. These changes have since moved to #269.