Sdk style (more cross-platform compatibility)#33
Open
gkarabin wants to merge 2 commits intoprasannavl:masterfrom
Open
Sdk style (more cross-platform compatibility)#33gkarabin wants to merge 2 commits intoprasannavl:masterfrom
gkarabin wants to merge 2 commits intoprasannavl:masterfrom
Conversation
Use SDK style project, eliminating dependency on Microsoft.NETCore.Portable.Compatibility in the process.
Also convert the sample to SDK style.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the csproj files to use the SDK style system and rev's the version to 8.3.0.
P.S. My motivation for this PR is that I work on an application that uses LiquidState 8.0.2 on a Xamarin platform. We haven't updated to LiquidState 8.2.0 because the dependency that was added on"Microsoft.NETCore.Portable.Compatibility" isn't appropriate for Xamarin projects - its presence generates thousands of errors - many assemblies with equivalent identity are imported due to assemblies being provided both in the portability code and in Xamarin code.
Using the SDK style, it's clear that a .NET Framework 4.5.2 project doesn't need that dependency (or the .NET Standard dependency which is providing by Visual Studio tooling these days). The end result is a package that installs cleanly in a .NET Framework 4.5.2 project or a Xamarin project.