Throttling feature is added, for performance. #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's new, TLDR
By printing progress bar only when it is needed, performance got better.
Added ETA(Estimated time of arrival), and Spinner.
It is just one header file, like original.
What's new and why, in detail
Throttling added
Displaying progress is important, but when printing too much console from your program, your program slows down. That's what exactly happened to me when using original library. So I added throttling feature, to print the progress bar only when it is needed. When
throttle_progressis set to 1(default), then program will display the progress bar only when percentage changes. If we setthrottle_progresslarger than 1, then it will skip printing progress bar until added progress percentage gets larger thanthrottle_progress.ETA added
Time estimation is added. It can be enabled/disabled by variable
is_eta_enabledSpinner added
Spinner is added. It can be enabled/disabled by variable
is_spinner_enabled/// disclaimer
This is my first contribution in github using 'create pull request'. If something's wrong, please let me know so that I could learn from my mistakes. Good day!