Skip to content

Conversation

@google-labs-jules
Copy link

This PR addresses a CRITICAL security vulnerability where database credentials were hardcoded in code/collection/dbconfig.ini.

Changes:

  1. Deleted code/collection/dbconfig.ini.
  2. Modified code/collection/databaseHandler.py to:
    • Use os.environ.get() to read credentials (DB_USER, DB_PASSWD, DB_HOST, DB_NAME, etc.).
    • Fallback to reading dbconfig.ini if environment variables are missing (for local dev).
    • Fix ConfigParser import for Python 3 compatibility.
  3. Resolved merge conflicts in requirements.txt to allow successful dependency installation.

Verification:

  • The code now runs without dbconfig.ini present (assuming env vars are set or connection fails gracefully).
  • Secrets are no longer in the codebase.

PR created automatically by Jules for task 15520871591335115646 started by @prajitdas

- Deleted `code/collection/dbconfig.ini` which contained hardcoded secrets.
- Updated `code/collection/databaseHandler.py` to prioritize environment variables for database configuration.
- Added fallback to `dbconfig.ini` if environment variables are not present.
- Fixed `requirements.txt` merge conflicts.
- Updated imports in `databaseHandler.py` to support Python 3.
@google-labs-jules
Copy link
Author

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!


For security, I will only act on instructions from the user who triggered this task.

New to Jules? Learn more at jules.google/docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant