🛡️ Sentinel: [CRITICAL] Remove hardcoded database credentials #23
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses a CRITICAL security vulnerability where database credentials were hardcoded in
code/collection/dbconfig.ini.Changes:
code/collection/dbconfig.ini.code/collection/databaseHandler.pyto:os.environ.get()to read credentials (DB_USER,DB_PASSWD,DB_HOST,DB_NAME, etc.).dbconfig.iniif environment variables are missing (for local dev).ConfigParserimport for Python 3 compatibility.requirements.txtto allow successful dependency installation.Verification:
dbconfig.inipresent (assuming env vars are set or connection fails gracefully).PR created automatically by Jules for task 15520871591335115646 started by @prajitdas