-
Notifications
You must be signed in to change notification settings - Fork 18
feat: allow to customize AMARU_TRACE when running e2e tests #642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. WalkthroughAdds a Changes
Sequence Diagram(s)sequenceDiagram
rect rgba(30,144,255,0.5)
participant User
end
rect rgba(34,139,34,0.5)
participant GitHub_Actions as "GitHub Actions"
end
rect rgba(255,140,0,0.5)
participant Demo_Script as "demo script / runtime"
end
rect rgba(128,0,128,0.5)
participant Cargo as "cargo / app"
end
User->>GitHub_Actions: Trigger workflow (optional demo_trace_level)
GitHub_Actions->>GitHub_Actions: Map input -> AMARU_TRACE env
GitHub_Actions->>Demo_Script: Start demo job with AMARU_TRACE set
Demo_Script->>Demo_Script: Apply inline default if unset
Demo_Script->>Cargo: Invoke `cargo run` with AMARU_TRACE env
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. 🚀 New features to boost your workflow:
|
etorreborre
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🏎️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request adds the ability to customize the AMARU_TRACE environment variable when running end-to-end tests through the CI workflow. Previously, the trace level was hardcoded to amaru=info in the demo script.
Changes:
- Added a new workflow input parameter
demo_trace_levelto allow customization of AMARU_TRACE - Modified the demo script to use the AMARU_TRACE environment variable with a fallback to the default value
- Removed the unused INPUT_DEMO_TARGET_EPOCH environment variable from the workflow (the input parameter still exists)
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| scripts/demo | Modified to use AMARU_TRACE from environment with default fallback, removing the hardcoded export |
| .github/workflows/continuous-integration.yml | Added demo_trace_level input parameter and set AMARU_TRACE environment variable |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
2d4214d to
72de085
Compare
Signed-off-by: jeluard <jeluard@users.noreply.github.com>
72de085 to
99dd85c
Compare
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.