Skip to content

Conversation

@jeluard
Copy link
Contributor

@jeluard jeluard commented Jan 21, 2026

Summary by CodeRabbit

  • Chores
    • CI workflow: added a new optional input to configure the demo trace level for runs.
    • Demo script: applies an optional trace-level setting at invocation and removed the prior global export.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 21, 2026

Warning

Rate limit exceeded

@etorreborre has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 13 minutes and 28 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

Walkthrough

Adds a demo_trace_level workflow_dispatch input mapped to AMARU_TRACE in CI, removes the old INPUT_DEMO_TARGET_EPOCH mapping, and moves the AMARU_TRACE default into the scripts/demo invocation as an inline fallback (AMARU_TRACE=${AMARU_TRACE:-amaru=info}).

Changes

Cohort / File(s) Summary
GitHub Actions Workflow
.github/workflows/continuous-integration.yml
Added demo_trace_level workflow_dispatch input; mapped it to AMARU_TRACE in the workflow env; removed previous INPUT_DEMO_TARGET_EPOCH env mapping.
Demo Script
scripts/demo
Removed global export AMARU_TRACE="amaru=info"; added inline defaulting at invocation: AMARU_TRACE=${AMARU_TRACE:-amaru=info} cargo run ....

Sequence Diagram(s)

sequenceDiagram
    rect rgba(30,144,255,0.5)
    participant User
    end
    rect rgba(34,139,34,0.5)
    participant GitHub_Actions as "GitHub Actions"
    end
    rect rgba(255,140,0,0.5)
    participant Demo_Script as "demo script / runtime"
    end
    rect rgba(128,0,128,0.5)
    participant Cargo as "cargo / app"
    end

    User->>GitHub_Actions: Trigger workflow (optional demo_trace_level)
    GitHub_Actions->>GitHub_Actions: Map input -> AMARU_TRACE env
    GitHub_Actions->>Demo_Script: Start demo job with AMARU_TRACE set
    Demo_Script->>Demo_Script: Apply inline default if unset
    Demo_Script->>Cargo: Invoke `cargo run` with AMARU_TRACE env
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🍀 A wee tweak in the CI light,
Trace set tidy, ready to flight,
Script whispers defaults at run,
Cargo hums — the show’s begun.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: adding customization capability for AMARU_TRACE in e2e tests through workflow dispatch input.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Jan 21, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
see 6 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jeluard jeluard requested a review from etorreborre January 22, 2026 12:28
Copilot AI review requested due to automatic review settings January 26, 2026 13:11
Copy link
Contributor

@etorreborre etorreborre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏎️

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request adds the ability to customize the AMARU_TRACE environment variable when running end-to-end tests through the CI workflow. Previously, the trace level was hardcoded to amaru=info in the demo script.

Changes:

  • Added a new workflow input parameter demo_trace_level to allow customization of AMARU_TRACE
  • Modified the demo script to use the AMARU_TRACE environment variable with a fallback to the default value
  • Removed the unused INPUT_DEMO_TARGET_EPOCH environment variable from the workflow (the input parameter still exists)

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
scripts/demo Modified to use AMARU_TRACE from environment with default fallback, removing the hardcoded export
.github/workflows/continuous-integration.yml Added demo_trace_level input parameter and set AMARU_TRACE environment variable

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@etorreborre etorreborre force-pushed the jeluard/demo-amaru-trace branch 3 times, most recently from 2d4214d to 72de085 Compare January 26, 2026 14:54
Signed-off-by: jeluard <jeluard@users.noreply.github.com>
@etorreborre etorreborre force-pushed the jeluard/demo-amaru-trace branch from 72de085 to 99dd85c Compare January 26, 2026 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants