Skip to content

Recalibrate detection severity ratings#5

Open
praetorian-rang wants to merge 6 commits intomainfrom
fix/recalibrate-detection-severity
Open

Recalibrate detection severity ratings#5
praetorian-rang wants to merge 6 commits intomainfrom
fix/recalibrate-detection-severity

Conversation

@praetorian-rang
Copy link
Collaborator

@praetorian-rang praetorian-rang commented Mar 12, 2026

Summary

Severity ratings across detection plugins need fine tuning. This PR recalibrates them

Severity adjustments:

  • Unpinned actions/includes and missing environment protections are now LOW — these are hygiene issues, not directly exploitable.
  • TOCTOU (mutable ref checkout) moves from HIGH to MEDIUM to reflect the conditional nature of exploitation.
  • ADO fork build secrets exposure moves from MEDIUM to HIGH — fork-accessible secrets are a concrete risk.
  • All AI-specific detections are capped at MEDIUM. Prompt injection is probabilistic and model-dependent

Infrastructure cleanup:

  • Removed DefaultSeverities map, GetDefaultSeverity, BuildAllZeroAggregation, and the hideZero parameter threading. All platforms already hid zero-count rows, so this code had no effect.
  • Unified the --list output format across platforms.

Test plan

  • Full test suite passing
  • Live validation against GitHub, GitLab, and ADO test instances

Closes LAB-1429

praetorian-rang and others added 6 commits March 11, 2026 19:04
Remove DefaultSeverities map, GetDefaultSeverity, BuildAllZeroAggregation,
AggregateByRepo wrapper, hideZero parameter, and Jenkins --hide-zero CLI flag.
All platforms already defaulted to hiding zero-count rows; this removes the
dead code path that displayed vulnerability types with zero findings.

LAB-1429

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- environment-bypass: HIGH -> LOW (missing config, not active vuln)
- dispatch-toctou: HIGH -> MEDIUM (requires collaborator access + race)
- unpinned-action (GitHub): HIGH -> LOW (supply chain, not direct vuln)
- unpinned-include (GitLab): HIGH -> LOW (same rationale)
- secrets-exposure fork build (ADO): MEDIUM -> HIGH (direct exfil path)

LAB-1429

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
AI detections depend on prompt injection succeeding, which is probabilistic
and model-dependent — unlike script injection which is deterministic RCE.
No AI detection exceeds MEDIUM severity. Applies across all four platforms:
GitHub, Azure DevOps, GitLab, and Bitbucket.

LAB-1429

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Remove the separate "AI Security Detections" section from GitHub's --list
output. AI detections are now grouped by severity alongside all other
detections, matching the GitLab and ADO format.

LAB-1429

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Update ~17 test comments and 1 doc comment that still referenced old
CRITICAL/HIGH severity levels after the recalibration to MEDIUM/LOW.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
MCP untrusted-only findings were recalibrated from MEDIUM to LOW but
the test comments still said MEDIUM.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant