feat: add optional ariaLabel prop#532
Merged
pradel merged 3 commits intopradel:masterfrom Oct 1, 2025
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #532 +/- ##
=======================================
Coverage 78.46% 78.46%
=======================================
Files 8 8
Lines 195 195
Branches 73 73
=======================================
Hits 153 153
Misses 32 32
Partials 10 10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add optional
ariaLabelPropSummary
This PR introduces an optional
ariaLabelprop to theModalcomponent, allowing developers to ensure all modals are properly labeled for screen reader users in a more flexible way.Changes
ariaLabelprop toModalPropsinterfacearia-labelattribute to the modal containerWhy is this needed?
According to the W3C ARIA Authoring Practices for Modals, every modal must have an accessible label:
Currently, the component only supports
ariaLabelledby, which requires referencing a visible element with an ID. However, referencing a visible element is not always possible or practical. Some modals may not have a clear title element, or the visible title may not be the most descriptive for accessibility purposes. In other cases, developers may be forced to create artificial hidden elements solely for screen readers, adding unnecessary complexity and markup.Example Use Cases
❌ Without
ariaLabel(forces artificial markup)✅ With ariaLabel (clean and semantic)
Testing