Fix unplugging controller sometimes crashing game #6692
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Could crash if the ID wasn't in the dictionary. The old code also didn't properly close everything (it would close either the jostick or the gamepad, but not both).
|
Sentry issue: OSU-1028 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Could crash if the ID wasn't in the dictionary. The old code also didn't properly close everything (it would close either the joystick or the gamepad, but not both).
This PR adds
removeJoystick()(matchingaddJoystick()) and uses it when a joystick or gamepad is removed, for both SDL2 and SDL3.